fix(lint): replace Array.sort with toSorted and unify defineEmits overload #4

Merged

BothimTV merged 1 commit from fix-linting-issues into main

2026-01-29 18:09:11 +00:00

BothimTV commented

2026-01-29 18:08:25 +00:00

(Migrated from github.com)

No description provided.

coderabbitai[bot] commented

2026-01-29 18:08:35 +00:00

(Migrated from github.com)

📝 Walkthrough

Walkthrough

The changes consolidate type signatures in one component and replace mutating array sort operations with non-mutating toSorted() calls across multiple pages. This improves immutability practices without altering runtime behavior or result ordering of data processing.

Changes

Cohort / File(s)	Summary
Type Signature Consolidation `frontend/src/components/SchuelerSelect.vue`	Emit definition refactored from two separate overloads to a single union-type signature for 'selected' \| 'update:modelValue', preserving type checking without functional changes.
Sort Method Migration `frontend/src/pages/checkin.vue`, `frontend/src/pages/verwaltung/schueler.vue`, `frontend/src/pages/verwaltung/statistik.vue`	Multiple instances of mutating `sort()` replaced with non-mutating `toSorted()` in grouped key sorting and computed property sorting operations to enhance immutability.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With toSorted whispers so neat,
We dance through arrays, never repeat,
Type signatures unified, clean and tight,
Immutability shines ever bright!

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

<details> <summary>📝 Walkthrough</summary> ## Walkthrough The changes consolidate type signatures in one component and replace mutating array sort operations with non-mutating `toSorted()` calls across multiple pages. This improves immutability practices without altering runtime behavior or result ordering of data processing. ## Changes |Cohort / File(s)|Summary| |---|---| |**Type Signature Consolidation** <br> `frontend/src/components/SchuelerSelect.vue`|Emit definition refactored from two separate overloads to a single union-type signature for 'selected' \| 'update:modelValue', preserving type checking without functional changes.| |**Sort Method Migration** <br> `frontend/src/pages/checkin.vue`, `frontend/src/pages/verwaltung/schueler.vue`, `frontend/src/pages/verwaltung/statistik.vue`|Multiple instances of mutating `sort()` replaced with non-mutating `toSorted()` in grouped key sorting and computed property sorting operations to enhance immutability.| ## Estimated code review effort 🎯 2 (Simple) | ⏱️ ~8 minutes ## Poem > 🐰 *With toSorted whispers so neat,* > *We dance through arrays, never repeat,* > *Type signatures unified, clean and tight,* > *Immutability shines ever bright!* </details>   --- > [!NOTE] > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>

Commenting is not possible because the repository is archived.

No reviewers